Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Introduction to JavaScript #138

Merged
merged 4 commits into from Nov 27, 2020
Merged

Conversation

@longo-andrea
Copy link
Contributor

@longo-andrea longo-andrea commented Nov 25, 2020

Reviewed An Introduction to JavaScript article. I have already make a grammar check, only a review is needed.

@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-it Nov 25, 2020
@javascript-translate-bot

Error: the article already translated in the Progress Issue #1 ⁉️

@longo-andrea
Copy link
Contributor Author

@longo-andrea longo-andrea commented Nov 25, 2020

Error: the article already translated in the Progress Issue #1 ⁉️

Just a review of an already translated article

Copy link
Contributor

@mean2me mean2me left a comment

I just propose minor changes to make it more readable and smooth for italians. It'd be good enough as is anyway.

1-js/01-getting-started/1-intro/article.md Outdated Show resolved Hide resolved
1-js/01-getting-started/1-intro/article.md Outdated Show resolved Hide resolved
@longo-andrea
Copy link
Contributor Author

@longo-andrea longo-andrea commented Nov 26, 2020

I just propose minor changes to make it more readable and smooth for italians. It'd be good enough as is anyway.

Yes, those two paragraphs have been translated too literally, thanks for review! I already made the changes. If you thinks that is okay, feel free to merge the PR.

@mean2me mean2me merged commit dc28387 into javascript-tutorial:master Nov 27, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot

Error: the article already translated in the Progress Issue #1 ⁉️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.