Skip to content

/ it.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contributing.md #164

Merged
merged 4 commits into from Jan 15, 2021
Merged

Improve contributing.md #164

merged 4 commits into from Jan 15, 2021

Conversation

@pasor1
Copy link
Contributor

@pasor1 pasor1 commented Jan 10, 2021

Ho riscritto il file CONTRIBUTING.MD , sicuramente andrà ritoccato qua e là, spero di non aver dimenticato nulla di importante, nel caso aggiungete 😉
pasor1 added 2 commits Jan 10, 2021
@pasor1
improving contributing gudelines
bbd50ee
@pasor1
Added a little note about the local server
Loading status checks…
a60eee0
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-it Jan 10, 2021
@longo-andrea
longo-andrea reviewed Jan 10, 2021
View changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@longo-andrea
Copy link
Contributor

@longo-andrea longo-andrea commented Jan 10, 2021

gli ho dato una letta veloce, hai fatto un bel lavoro 👏 volevo dargli una letta più approfondita domani, giusto per capire se c'è altro da aggiungere... comunque dire che puoi fare il merge e in caso creo una nuova PR
pasor1 and others added 2 commits Jan 14, 2021
@pasor1 @longo-andrea
Update CONTRIBUTING.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b0e403 
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
@pasor1 @longo-andrea
Update CONTRIBUTING.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d43d944 
Co-authored-by: Andrea  <45577511+longo-andrea@users.noreply.github.com>
@pasor1 pasor1 merged commit b12695b into javascript-tutorial:master Jan 15, 2021
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@pasor1 pasor1 deleted the pasor1:improve-contributing branch Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longo-andrea longo-andrea

Assignees

@pasor1 pasor1

Labels
changes requested
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@pasor1 @longo-andrea @javascript-translate-bot
You can’t perform that action at this time.