Skip to content

/ gitdb

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation : please specify the type of object_iter in write_pack. #23

Open
ytrezq opened this issue Nov 10, 2015 · 1 comment
Open

Documentation : please specify the type of object_iter in write_pack. #23

ytrezq opened this issue Nov 10, 2015 · 1 comment
Labels
acknowledged

Comments

@ytrezq
Copy link

@ytrezq ytrezq commented Nov 10, 2015

object_iter is a list, but of what type ?
Ostream or Oinfo.

I think it would worth to precise it.
@ytrezq ytrezq changed the title Documentation : please specify the type of object_iter in write_pack ? Documentation : please specify the type of object_iter in write_pack. Nov 10, 2015
@Byron Byron added the acknowledged label Nov 30, 2015
@Byron
Copy link
Member

@Byron Byron commented Nov 30, 2015

Indeed, thanks for letting me know.
I just reverse-engineered it by having a look at the tests. It seems that it expects an OPackStream compatible objects, as seen in the stream_iter() documentation.

I hope this answers your question, and would very much welcome a PR with documentation that would have helped you in the first place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Byron @ytrezq