Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42955: Remove sub-packages from sys.stdlib_module_names #24353

Merged
merged 1 commit into from Jan 27, 2021

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 27, 2021

@vstinner
Copy link
Member Author

@vstinner vstinner commented Jan 27, 2021

Tests / Ubuntu (pull_request) Failing

This is unrelated to my PR, FAIL: test_identify (tkinter.test.test_ttk.test_widgets.ComboboxTest).
https://bugs.python.org/issue42507

@vstinner
Copy link
Member Author

@vstinner vstinner commented Jan 27, 2021

@vstinner
Copy link
Member Author

@vstinner vstinner commented Jan 27, 2021

@gaborbernat @warsaw @gpshead: What do you think of this change?

@gpshead
Copy link
Member

@gpshead gpshead commented Jan 27, 2021

To me, this makes sense. The use case we've had at work for an official list of what modules are in the standard library has been in code health tooling. Sorting stdlib imports before others, etc. Only the top level package names are important there.

@vstinner vstinner merged commit 64fc105 into python:master Jan 27, 2021
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20210127.6 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 42955 found
Details
bedevere/news "skip news" label found
@vstinner vstinner deleted the vstinner:remove_subpackages branch Jan 27, 2021
@vstinner
Copy link
Member Author

@vstinner vstinner commented Jan 27, 2021

Merged, thanks @gpshead.

Well, I wasn't fully comfortable with the half-baken trade-off: include sub-packages but not sub-modules. IMO the new API is now more consistent: only list main packages.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 27, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit 64fc105.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/464/builds/742) and take a look at the build logs.
  4. Check if the failure is related to this commit (64fc105) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/464/builds/742

Summary of the results of the build (if available):

Click to see traceback logs
remote: Not Found
fatal: repository 'https://github.com/python/cpython.git/' not found

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.
m000 added a commit to m000/cpython that referenced this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants