C#: Extract 'and' and 'or' patterns #5018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5da939 to
e24e5b1
Compare
hvitved
requested changes
Jan 27, 2021
csharp/ql/src/semmle/code/csharp/controlflow/internal/ControlFlowGraphImpl.qll
Outdated
Show resolved
Hide resolved
hvitved
previously approved these changes
Jan 28, 2021
|
The new pattern matching completion changes result in a lot of noise or false positives in the new constant condition check. |
That should be fixed by the CFG changes I was working on, so happy to merge this now. |
hvitved
approved these changes
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFG for
andandorpatterns look like: and.pdf, or.pdfMissing
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/806/https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/809/https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/813/