PEP 558: Make fast locals proxy independent of the legacy dynamic snapshot #1787
+166
−85
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This incorporates @markshannon's suggestion that the fast locals proxy only access the underlying frame storage, and not support writing additional keys to the dynamic snapshot stored in the C level
f_localsstruct field.It also summarises the proposed CPython implementation changes, and cleans up quite a few old references to the idea of storing an instance of the fast locals proxy in the C level
f_localsstruct field (that hasn't been part of the proposal for ages, but it turned out there were still a lot of references to things working that way that I had missed).