Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-11717: fix ssize_t redefinition error when targeting Win32 app #24479

Merged
merged 1 commit into from Mar 1, 2021
Merged

bpo-11717: fix ssize_t redefinition error when targeting Win32 app #24479

merged 1 commit into from Mar 1, 2021

Conversation

JoeyGrajciar
Copy link
Contributor

@JoeyGrajciar JoeyGrajciar commented Feb 8, 2021 •
edited

Co-authored-by: Amaury Forgeot d'Arc amauryfa@gmail.com

https://bugs.python.org/issue11717

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Feb 8, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@JoeyGrajciar

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Fidget-Spinner
Fidget-Spinner reviewed Feb 8, 2021
View changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment •
edited

Thanks for taking the time to make this PR (and welcome to Cpython contribution)!
I just have one question:

Edit:
I also forgot to mention, I think you should add a Co-authored-by: Amaury Forgeot d'Arc <amauryfa@gmail.com> to your first message (right above the bugs.python.org link), as this partly uses their patch ;). You can read more about what that is here.

Include/pyport.h Show resolved Hide resolved
@JoeyGrajciar
Copy link
Contributor Author

@JoeyGrajciar JoeyGrajciar commented Feb 8, 2021

I also forgot to mention, I think you should add a Co-authored-by: Amaury Forgeot d'Arc <amauryfa@gmail.com> to your first message

Sure thing :) added to commit message and also to description of PR.

pablogsal
pablogsal requested changes Mar 1, 2021
View changes
Parser/parser.c Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 1, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@JoeyGrajciar @amauryfa
bpo-11717: fix ssize_t redefinition error when targeting 32bit Window…
0ef3ac9 
…s app

Co-authored-by: Amaury Forgeot d'Arc <amauryfa@gmail.com>
@JoeyGrajciar
Copy link
Contributor Author

@JoeyGrajciar JoeyGrajciar commented Mar 1, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 1, 2021

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from pablogsal Mar 1, 2021
@pablogsal pablogsal merged commit c994ffe into python:master Mar 1, 2021
10 checks passed
kreathon pushed a commit to kreathon/cpython that referenced this issue May 2, 2021
@JoeyGrajciar @kreathon
bpo-11717: fix ssize_t redefinition error when targeting 32bit Window…
94ca327 
…s app (pythonGH-24479)
@mattip mattip mentioned this pull request May 3, 2021
Closed
seberg pushed a commit to numpy/numpy that referenced this issue May 4, 2021
@mattip
MAINT: ssize_t -> Py_ssize_t and other fixes for Python v3.10.0 (gh-1…
ccfd68d 
…8890)

The 3.10 alpha 7 fails to build on windows, see below for the warnings and errors. It seems we should not be using ssize_t rather Py_ssize_t. On windows, ssize_t is not defined anymore in CPython3.10 alpha7 after python/cpython#24479 in response to issue 17717 from 2011, which was merged March 1.

Fixes #18888
@mattip mattip mentioned this pull request May 4, 2021
Merged
@cgohlke cgohlke mentioned this pull request Aug 5, 2021
Merged
@cgohlke cgohlke mentioned this pull request Aug 5, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner

@pablogsal pablogsal

@lysnikolaou lysnikolaou

@python/windows-team windows-team

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JoeyGrajciar @the-knights-who-say-ni @bedevere-bot @pablogsal @Fidget-Spinner @lysnikolaou