Skip to content

Fixed CPython failing to build from source on Cygwin #24506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fixed CPython failing to build from source on Cygwin #24506

wants to merge 3 commits into from

Conversation

TheShermanTanker
Copy link
Contributor

I was not able to find a corresponding bug logged anywhere, unfortunately. It appears that this issue has been under-reported

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@TheShermanTanker

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@@ -359,7 +359,7 @@ xxsubtype xxsubtype.c
# Uncommenting the following line tells makesetup that all following modules
# are not built (see above for more detail).
#
#*disabled*
*disabled*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hummm.... this looks incorrect. Why is this being changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, it appears that I left it there by mistake

@@ -1,5 +1,6 @@
#include <Python.h>
#include <errcode.h>
#include <errno.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

@pablogsal
Copy link
Member

I was not able to find a corresponding bug logged anywhere, unfortunately. It appears that this issue has been under-reported

Please, open an issue on bpo so we can also discuss the problem there.

@TheShermanTanker
Copy link
Contributor Author

I was not able to find a corresponding bug logged anywhere, unfortunately. It appears that this issue has been under-reported

Please, open an issue on bpo so we can also discuss the problem there.

Got it, will close PR and open issue on bpo, I'm confident the python team would be much more well equipped to handle this than I am (It's been driving me insane so far)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants