Fix copy/pasta in label_short_desc#3769
Merged
ethanpalm merged 3 commits intogithub:mainfrom Feb 25, 2021
Merged
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
@chadwhitacre Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
Contributor
|
@chadwhitacre This looks great 👍 Thanks for catching that typo and opening a PR to fix it! I'll update the branch and get this merged posthaste once tests are passing. 🍏 |
ethanpalm
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
I'm working on adding label names to our GitHub events pipeline so that I can derive some metrics from label changes. Based on prior art in our repo I'm pulling payload examples from the docs to use as test fixture. This is where I ran across
label_short_descin the wild, and I was confused because it made me think maybe the labels payload is about the application of a label to an issue, when in fact of course it's about the label itself.What's being changed:
The word "issue" is being changed to "label" (with subordinate emendation in preservation of articular agreement), fixing presumably a scribal error deriving from the derivation of
label_short_descfromissue_short_descwithout sufficient original modification of the original, herein forsooth forthwith corrected.Check off the following: