fix(@angular-devkit/build-angular): fix aot mode for web worker#19908
fix(@angular-devkit/build-angular): fix aot mode for web worker#19908moczix wants to merge 1 commit into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
@alan-agius4 can you review? or set the target? or did i do something wrong here? |
|
Hi @moczix, Thanks for your contribution, however this is the intended behaviour. Can you please elaborate your use case a bit more to why you need Angular DI in a worker? Thanks. |
|
@alan-agius4 , i made app similar to your deprecated ui worker thread. But in my case i placed in worker only business logic, and it was cool to have angular DI in worker |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
i setup angular app in web-worker to use angular DI powers. It all worked well until i build production build. I got error about something bootstrap of undefined. I started investigate angular sources, and found this code.
With aot flag set to false my angularApp inside web-worker with production build doesnt have ivy metadata like "emod".
Comparing this flag to other flags about aot i didnt find out why this flag is set to false. So i made if condition like other places