Java: Fix some predicates being incorrect for Records #5473
Conversation
|
File "ql/java/ql/src/semmle/code/java/Type.qll" contains a non-ASCII character at the location marked with ASCII check failed! |
|
Yeah, I know, I added the the section sign If you want I can replace / remove those Note however, that as mentioned in the description there is currently little value in merging this pull request. Sorry that this comment is somewhat reproachful, it just feels so uncomfortable to create pull requests which fail, wasting your and my time. If I would at least see the CI failure I could (hopefully) fix problems because you even have a first look on it. |
|
Tested this against the latest extractor: can confirm the tests pass without the QL changes (i.e., the extractor is populating the implicit modifiers for us) |
|
Just the test merged as #6604, as the extractor is already flagging these classes as static and/or final for us. |
|
@smowton, thanks for merging the tests. Ideally the |
|
Happy to merge a docs change (don't use the section character §, since the codeql source code is intentionally entirely ASCII). Probably worth noting that the extractor provides some of the advertised functionality. On cleaning up any duplication between the extractor and the QL library, I'm disinclined to spend time on it: we can only possibly make the situation worse for users, and I'll need to check I've written an exhaustive suite of tests to be sure I haven't introduced a regression. |
Properly implements the predicates for
Recordclasses and adds tests.Note: At the current state this pull request is pointless because
Modifiable.hasModifierreports implicit modifiers (see #5472); once this has been fixed, this pulll request is necessary.The text was updated successfully, but these errors were encountered: