Make the default github.com path consistent with other paths#401
Closed
aeisenberg wants to merge 1 commit intogithub:mainfrom
Closed
Make the default github.com path consistent with other paths#401aeisenberg wants to merge 1 commit intogithub:mainfrom
aeisenberg wants to merge 1 commit intogithub:mainfrom
Conversation
On util.ts:223, there is the following comment: ``` // Normalise path to having a trailing slash for consistency ``` However, I notice that the path defined by `GITHUB_DOTCOM_URL` does not have a trailing slash. This PR fixes it.
Contributor
|
One thing to note is that constant currently has to match the Something else I also spotted is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On util.ts:223, there is the following comment:
However, I notice that the path defined by
GITHUB_DOTCOM_URLdoes not have a trailing slash. This PR fixes it.
I'm not 100% sure this is valid, so feel free to close if it doesn't make sense.
Though, if we don't go with this PR, then we should probably remove the requirement for a trailing
/for other URIs.Merge / deployment checklist