Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploying-to-google-kubernetes-engine.md #3488

Open
wants to merge 1 commit into
base: main
from

Conversation

@dmlls
Copy link

@dmlls dmlls commented Feb 5, 2021

Why:

Without adding the role container.clusterViewer to the created service account I was getting the error: Error: Required "container.clusters.get" permission(s) when running google-github-actions/get-gke-credentials@v0.2.1. Adding that role, as stated in the action readme fixed it.

Also, I believe there was a mistake in the step "Store the project ID as a secret named GKE_PROJECT", since then the GKE_SA_KEY was exported.

What's being changed:

  • Add the role container.clusterViewer to the created service account.
  • Fix misleading step when creating secret for GKE_SA_KEY.

Check off the following:

Without adding the role `container.clusterViewer` to the created service account I was getting the error: `Error: Required "container.clusters.get" permission(s)` when running `google-github-actions/get-gke-credentials@v0.2.1`. Adding that role, as stated in the [action readme](https://github.com/marketplace/actions/get-gke-credentials#authorization) fixed it.

Also, I believe there was a mistake in the step "Store the project ID as a secret named `GKE_PROJECT`", since then the `GKE_SA_KEY` was exported.
@welcome
Copy link

@welcome welcome bot commented Feb 5, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@deploy-to-heroku deploy-to-heroku bot temporarily deployed to docs-3488--patch-1 Feb 5, 2021 Inactive
@janiceilene
Copy link
Collaborator

@janiceilene janiceilene commented Feb 5, 2021

@dmlls Thanks so much for opening a PR! I'll get this triaged for review

@janiceilene janiceilene added this to Ecosystem in Docs team reviews Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
Docs team reviews automation moved this from Ecosystem to Done Feb 13, 2021
@janiceilene
Copy link
Collaborator

@janiceilene janiceilene commented Feb 16, 2021

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 24, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale label Feb 24, 2021
@dmlls
Copy link
Author

@dmlls dmlls commented Feb 24, 2021

Just commenting to prevent the PR from being closed by the bot.

@github-actions github-actions bot removed the stale label Feb 25, 2021
@janiceilene janiceilene moved this from Done to Help wanted in Docs team reviews Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants