Skip to content

C#: Fix special case of default argument value extraction#5745

Merged
tamasvajk merged 1 commit into
github:mainfrom
tamasvajk:feature/fix-arg-default
Apr 22, 2021
Merged

C#: Fix special case of default argument value extraction#5745
tamasvajk merged 1 commit into
github:mainfrom
tamasvajk:feature/fix-arg-default

Conversation

@tamasvajk

@tamasvajk tamasvajk commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

This PR fixes default argument value extraction in a special case found in assemblies compiled from vb.net. Vb.net allows specifying default argument values for parameters of type object where the value is not null.

Differences job

@tamasvajk tamasvajk force-pushed the feature/fix-arg-default branch from 9d8362c to a0f5e45 Compare April 21, 2021 14:34
@tamasvajk tamasvajk marked this pull request as ready for review April 21, 2021 14:36
@tamasvajk tamasvajk requested a review from a team as a code owner April 21, 2021 14:36
@tamasvajk tamasvajk added the no-change-note-required This PR does not need a change note label Apr 21, 2021

@hvitved hvitved left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tamasvajk tamasvajk merged commit a7cc9f9 into github:main Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants