Revert "Revert "C++: Work around extractor issue CPP-383""#5696
Merged
Conversation
**Revert the revert** of the workaround for CFG issues when a `FunctionCall` has a `getTarget` that does not exist. While we've fixed the main cause of the problem, it can apparently still happen in rare cases as a result of extractor crashes. This reverts commit ee5eaef.
criemen
reviewed
Apr 16, 2021
|
|
||
| /** | ||
| * Holds if `fc` is a `FunctionCall` with no return value for `getTarget`. This | ||
| * can happen due to extractor issue CPP-383. |
Collaborator
There was a problem hiding this comment.
Can we link to the new issue from Luke here?
Contributor
Author
There was a problem hiding this comment.
The problem of no getTarget value can in principle be caused by any extractor crash, so I've changed this comment to avoid mentioning a specific issue.
criemen
reviewed
Apr 16, 2021
| ) | ||
| } | ||
|
|
||
| // This base case is pulled out to work around QL-796 |
Collaborator
There was a problem hiding this comment.
Do we have a GH issue for this instead?
Contributor
Author
There was a problem hiding this comment.
We do now. I've updated all references to QL-796. We decided on Slack that it's okay to link to this internal issue from code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the revert of the workaround for CFG issues when a
FunctionCallhas agetTargetthat does not exist. While we've fixed the main cause of the problem, it can apparently still happen in rare cases as a result of extractor crashes.This reverts commit ee5eaef.
Cc @lcartey.