JS: Add file diagnostics queries #5656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbena
previously approved these changes
Apr 12, 2021
erik-krogh
previously approved these changes
Apr 12, 2021
Contributor
erik-krogh
left a comment
There was a problem hiding this comment.
I think it would be nice to have tests for these new queries.
But if you don't think so, that's also fine with me.
Otherwise LGTM.
erik-krogh
approved these changes
Apr 12, 2021
esbena
approved these changes
Apr 12, 2021
adityasharad
approved these changes
Apr 12, 2021
Collaborator
adityasharad
left a comment
There was a problem hiding this comment.
Looks good!
Toolchain support for the new kind is underway in the coming weeks (cc @henrymercer). If you'd like to merge this PR before that's ready, then you may wish to turn off the fail-on-warnings mode for your language tests.
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Apr 23, 2021
This is basically just a port of the C++/JS queries added in: - github#5414 (C++) - github#5656 (JS) SyntaxError should capture all errors we have information about. At least in `python/ql/src/semmlecode.python.dbscheme` the only match for `error` is `py_syntax_error_versioned` (which `SyntaxError` is based on).
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Apr 23, 2021
This is basically just a port of the C++/JS queries added in: - github#5414 (C++) - github#5656 (JS) SyntaxError should capture all errors we have information about. At least in `python/ql/src/semmlecode.python.dbscheme` the only match for `error` is `py_syntax_error_versioned` (which `SyntaxError` is based on).
Member
|
Internal tools have been updated to allow using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostic queries for showing files that were extracted and files with extraction errors, based on those from C++.
In general it's possible for a file to be partially extracted, e.g. an HTML file with an event attribute we couldn't parse, or a JS file with an invalid regexp literal. However, the format of the
SuccessfullyExtractedFiles.qlquery requires us to make a binary decision for each file and say whether it was successful or not. So we're classifying errors as "fatal" based on a how likely it is that the main parts of the enclosing file couldn't be extracted.cc @adityasharad