bpo-35114: Make ssl.RAND_status() return a bool (GH-20063)#20063
bpo-35114: Make ssl.RAND_status() return a bool (GH-20063)#20063tiran merged 5 commits intopython:masterfrom
Conversation
ssl.RAND_status() returns either 1 or 0.
|
This is a "skip news" PR. |
tiran
left a comment
There was a problem hiding this comment.
Please fix the code instead of the documentation. RAND_status() should return a boolean.
The code is in Modules/_ssl.c, use PyBool_FromLong instead PyLong_FromLong, update the doc string, then run make clinic.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
I originally thought this PR didn't need a news entry. I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
tiran
left a comment
There was a problem hiding this comment.
Could you please rebase the PR and re-generate the clinic file? Thanks!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@ZackerySpytz Did you forget to tell Bederver that |
ssl.RAND_status() returns either 1 or 0.https://bugs.python.org/issue35114