Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30282: Fix name attribute of extracted object #1483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xondrejk
Copy link

@xondrejk xondrejk commented May 5, 2017

Attribute name of the extracted file object should hold filename of
itself rather than then of the archive it is contained in.

Attribute name of the extracted file object should hold filename of
itself rather than then of the archive it is contained in.
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented May 5, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@xondrejk
Copy link
Author

@xondrejk xondrejk commented May 5, 2017

Out of multiple options to tackle this, I've opted to not add another argument to _FileInFile retrieving the value for tarinfo.name on call and instead pass complete TarInfo instance and get the data from that. It seems to be OK with respect to the immediate state of code in the repo. I hope it's not too far off and move in the wrong direction.

Copy link

@auvipy auvipy left a comment

please add tests & release notes to ensure these changes won't create any regression

@github-actions
Copy link

@github-actions github-actions bot commented Feb 19, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review CLA signed stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants