gh-74706: IDLE: Add navigate bar and replace current goto dialog#1884
gh-74706: IDLE: Add navigate bar and replace current goto dialog#1884mlouielu wants to merge 5 commits intopython:mainfrom
Conversation
|
@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @tiran to be potential reviewers. |
Lib/idlelib/editor.py
Outdated
| return "break" | ||
| text.mark_set("insert", "%d.0" % lineno) | ||
| text.see("insert") | ||
| from idlelib.singlebar import NavigateBar |
There was a problem hiding this comment.
You named the file navigatebar
terryjreedy
left a comment
There was a problem hiding this comment.
As I will explain on the issue, I do not like the concept and am inclined to reject this.
- a bar with no title is confusing.
|
To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request. If/when the requested changes have been made, please leave a comment that says, |
|
This PR is stale because it has been open for 30 days with no activity. |
@terryjreedy, is this still your stance? If so, I'd like to mark this as pending close. |
|
I will try my alternate plan first (see issue), and even that is low priority. (I believe I have not heard from Louie since Sept. 2017.) |
Uh oh!
There was an error while loading. Please reload this page.