bpo-30799: Increase test coverage Lib/_osx_support 99% #2482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chexex, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ned-deily to be a potential reviewer. |
51d1cee to
ea0729a
Compare
gareth-rees
reviewed
Jul 6, 2017
Lib/test/test__osx_support.py
Outdated
| if cv in self.env: | ||
| self.env.unset(cv) | ||
|
|
||
| def tearDown(self): | ||
| super().tearDown() |
There was a problem hiding this comment.
Is it necessary to implement a method whose only job is to call the method in the superclass? If so, needs a comment explaining why.
There was a problem hiding this comment.
@gareth-rees yeah, indeed, there's no need in explicit call. Thank you.
ea0729a to
d190a10
Compare
d190a10 to
9775384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30799