bpo-30528: Fix IPv{4,6}Network reverse_pointer#3632
bpo-30528: Fix IPv{4,6}Network reverse_pointer#3632ekohl wants to merge 1 commit intopython:mainfrom
Conversation
Previous incorrect result for IPv4Network:
>>> ipaddress.IPv4Network('127.0.0.0/16').reverse_pointer
'0/16.0.0.127.in-addr.arpa'
New result:
>>> ipaddress.IPv4Network('127.0.0.0/16').reverse_pointer
'0.127.in-addr.arpa'
Previous incorrect result for IPv6Network:
>>> ipaddress.IPv6Network('2001:db8::/32').reverse_pointer
'2.3./.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8.b.d.0.1.0.0.2.ip6.arpa'
New result:
>>> ipaddress.IPv6Network('2001:db8::/32').reverse_pointer
'8.b.d.0.1.0.0.2.ip6.arpa'
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
I've signed the CLA and got a confirmation. Should the CLA not signed label be automatically removed? |
|
Hello there. Sorry for the meta posting, but I would like to review this PR. How can I review it and how can we proceed to backport it to 3.5 (according to Python official docs, ut says that |
|
@ekohl , could you include Misc/NEWS.d entry as stated in @bedevere-bot news check? ( No news entry in Misc/NEWS.d or "skip news" label found ) I am not aware how the reviews are distributed in this repo, but I would guess that at least all conflicts must be resolved to proceed. |
|
@ayharano there was some discussion in the issue so I think there first needs to be a consensus on the solution. I think the best place is to start reading there and get to a solution. We can then implement it. |
|
This PR is stale because it has been open for 30 days with no activity. |
Previous incorrect result for IPv4Network:
New result:
Previous incorrect result for IPv6Network:
New result:
https://bugs.python.org/issue30528