Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some minor inaccuracies in news #26096

Merged
merged 4 commits into from May 24, 2021
Merged

bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some minor inaccuracies in news #26096

merged 4 commits into from May 24, 2021

Conversation

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented May 13, 2021 •
edited by miss-islington

The fix only applies to isinstance. issubclass isn't affected (because it was always working to begin with). So I also fixed the news to reflect that.

https://bugs.python.org/issue38908

Automerge-Triggered-By: GH:gvanrossum
@Fidget-Spinner Fidget-Spinner changed the title bpo-38908: Add changes to 3.10 whatsnew and fix some minor inaccuracies in news bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some minor inaccuracies in news May 13, 2021
gvanrossum
gvanrossum reviewed May 13, 2021
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

I thought that the failure to raise only applied to Protocols with (only?) data items declared?

JelleZijlstra
JelleZijlstra reviewed May 13, 2021
View changes
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
@Fidget-Spinner
Copy link
Contributor Author

@Fidget-Spinner Fidget-Spinner commented May 13, 2021

I thought that the failure to raise only applied to Protocols with (only?) data items declared?

Yes. I'll update this by tomorrow (your time).

@Fidget-Spinner
Copy link
Contributor Author

@Fidget-Spinner Fidget-Spinner commented May 14, 2021 •
edited

@Fidget-Spinner wanted to know if there is a discord or community page for python contributors? Also how does one go about starting the process of contribution like finding an issue with such a repo?

Hi @Pretty-19 , thanks for your interest in contributing to Python. The official guide for CPython development is the devguide https://devguide.python.org/. It does a way better job answering your questions than I can.

Personally I also recommend https://realpython.com/start-contributing-python/ . It's much easier to follow for a completely new contributor.

BTW, you'll learn of better avenues to get help if you read those resources. Asking on a random pull request may not always be conducive (unless your question relates to the PR itself)!

@Fidget-Spinner Fidget-Spinner requested a review from gvanrossum May 23, 2021
gvanrossum
gvanrossum reviewed May 24, 2021
View changes
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
@Fidget-Spinner @gvanrossum
Update Doc/whatsnew/3.10.rst
0b6cece 
Co-authored-by: Guido van Rossum <guido@python.org>
@miss-islington miss-islington merged commit 8450e8a into python:main May 24, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 24, 2021

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue May 24, 2021
@Fidget-Spinner @miss-islington
bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some minor ina…
d04dd73 
…ccuracies in news (pythonGH-26096)

The fix only applies to ``isinstance``. ``issubclass`` isn't affected (because it was always working to begin with). So I also fixed the news to reflect that.
(cherry picked from commit 8450e8a)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 24, 2021

GH-26337 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue May 27, 2021
@Fidget-Spinner @miss-islington
[3.10] bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some mi…
09696a3 
…nor inaccuracies in news (GH-26096) (GH-26337)

The fix only applies to ``isinstance``. ``issubclass`` isn't affected (because it was always working to begin with). So I also fixed the news to reflect that.
(cherry picked from commit 8450e8a)


Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@Fidget-Spinner @JuniorJPDJ
bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some minor ina…
9a3df4b 
…ccuracies in news (pythonGH-26096)

The fix only applies to ``isinstance``. ``issubclass`` isn't affected (because it was always working to begin with). So I also fixed the news to reflect that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed 🤖 automerge type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@Fidget-Spinner @miss-islington @bedevere-bot @JelleZijlstra @gvanrossum @the-knights-who-say-ni