Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mark util.inherits as legacy #38896

Merged
merged 1 commit into from Jun 9, 2021
Merged

doc: mark util.inherits as legacy #38896

merged 1 commit into from Jun 9, 2021

Conversation

@VoltrexMaster
Copy link
Contributor

@VoltrexMaster VoltrexMaster commented Jun 1, 2021

Refs: #38893

Copy link
Member

@addaleax addaleax left a comment

:shipit:

@bl-ue
bl-ue approved these changes Jun 1, 2021
doc/api/util.md Outdated Show resolved Hide resolved
@aduh95
aduh95 approved these changes Jun 1, 2021
@lpinca
lpinca approved these changes Jun 2, 2021
@Lxxyx
Lxxyx approved these changes Jun 8, 2021
@jasnell
jasnell approved these changes Jun 8, 2021
PR-URL: #38896
Refs: #38893
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@aduh95 aduh95 force-pushed the VoltrexMaster:patch-3 branch from 5c33d2e to 7ce9592 Jun 9, 2021
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 9, 2021

Landed in 7ce9592

@aduh95 aduh95 merged commit 7ce9592 into nodejs:master Jun 9, 2021
12 checks passed
12 checks passed
@github-actions
build-tarball
Details
@github-actions
build-windows
Details
@github-actions
lint-addon-docs
Details
@github-actions
build-docs
Details
@github-actions
test-linux
Details
@github-actions
lint-cpp
Details
@github-actions
lint-md
Details
@github-actions
lint-js
Details
@github-actions
lint-py
Details
@github-actions
lint-sh
Details
@github-actions
lint-codeowners
Details
@github-actions
lint-pr-url
Details
@VoltrexMaster VoltrexMaster deleted the VoltrexMaster:patch-3 branch Jun 9, 2021
targos added a commit that referenced this pull request Jun 11, 2021
PR-URL: #38896
Refs: #38893
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
danielleadams added a commit that referenced this pull request Jun 17, 2021
PR-URL: #38896
Refs: #38893
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau added a commit that referenced this pull request Jul 19, 2021
PR-URL: #38896
Refs: #38893
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau added a commit that referenced this pull request Jul 20, 2021
PR-URL: #38896
Refs: #38893
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants