Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43693: Compute deref offsets in compiler #25152

Merged

Conversation

@markshannon
Copy link
Contributor

@markshannon markshannon commented Apr 2, 2021

Merges locals and cells into a single array.
Saves a pointer in the interpreter and means that we don't need the LOAD_CLOSURE opcode any more

https://bugs.python.org/issue43693

Python/ceval.c Show resolved Hide resolved
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Update also Doc/library/dis.rst.

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 5, 2021

Please don't forget to bump a bytecode magic number and add a line to the bytecode history list.

@ericsnowcurrently ericsnowcurrently force-pushed the faster-cpython:compile-deref-offsets-in-compiler branch 2 times, most recently from 6e4b212 to 8045347 Apr 23, 2021
@ericsnowcurrently ericsnowcurrently force-pushed the faster-cpython:compile-deref-offsets-in-compiler branch from 16546b6 to 6174448 May 7, 2021
@markshannon
Copy link
Contributor Author

@markshannon markshannon commented May 19, 2021

Eric is working on a PR to implement faster-cpython/ideas#41, so I'm closing this.

@ericsnowcurrently ericsnowcurrently force-pushed the faster-cpython:compile-deref-offsets-in-compiler branch from 6174448 to 46d531e Jun 3, 2021
@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jun 3, 2021

(What are you doing here?)

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 3, 2021

This change was always going to be included. I figured it would still be cleaner if it were its own PR. It also makes the subsequent PR a little smaller. (Plus it was already reviewed, between Mark and me, so I'll merge it today. 🙂)

@ericsnowcurrently ericsnowcurrently merged commit b2bf2bc into python:main Jun 4, 2021
11 of 12 checks passed
11 of 12 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR #20210603.54 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 43693 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants