Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinarySearch: clearer median computation #2182

Merged
merged 2 commits into from Apr 21, 2021
Merged

BinarySearch: clearer median computation #2182

merged 2 commits into from Apr 21, 2021

Conversation

@allentiak
Copy link
Contributor

@allentiak allentiak commented Apr 14, 2021 •
edited

">>> 1" is simply too obscure...

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
@allentiak
BinarySearch: clearer median computation
c77d6df 
">>> 1" is simply too obscure...
@yanglbme
yanglbme requested changes Apr 14, 2021
View changes
Searches/BinarySearch.java Outdated Show resolved Hide resolved
@shellhub @yanglbme
update binary search
3f3ba1f 
Co-authored-by: Yang Libin <contact@yanglibin.info>
@shellhub
shellhub approved these changes Apr 21, 2021
View changes
@shellhub shellhub merged commit d2d5efd into TheAlgorithms:master Apr 21, 2021
3 of 4 checks passed
3 of 4 checks passed
@github-actions
prettier prettier
Details
@github-actions
build
Details
@github-actions
format
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@allentiak allentiak deleted the allentiak:patch-1 branch May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme

@shellhub shellhub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@allentiak @yanglbme @shellhub