Python: Add modeling of peewee#6161
Merged
Merged
Conversation
So global namespace doesn't contain `Connection` whenever `PEP249.qll` is imported
For Peewee modeling I want to be able to define new cursor instances just like I can do for connections.
Notice that since this will be part of the same PR as 5cfc433, it is OK to do this change without keeping `PEP249::cursor` for backwards compatibility.
yoff
requested changes
Aug 17, 2021
yoff
left a comment
Contributor
There was a problem hiding this comment.
Only small things. Overall quite nice :-)
Comment on lines
+55
to
+65
| result = | ||
| API::moduleImport("playhouse") | ||
| .getMember("cockroachdb") | ||
| .getMember("CockroachDatabase") | ||
| .getASubclass*() | ||
| or | ||
| result = | ||
| API::moduleImport("playhouse") | ||
| .getMember("cockroachdb") | ||
| .getMember("PooledCockroachDatabase") | ||
| .getASubclass*() |
Contributor
There was a problem hiding this comment.
This list is quite long. It could become about half the size with rewrites like the following:
Suggested change
| result = | |
| API::moduleImport("playhouse") | |
| .getMember("cockroachdb") | |
| .getMember("CockroachDatabase") | |
| .getASubclass*() | |
| or | |
| result = | |
| API::moduleImport("playhouse") | |
| .getMember("cockroachdb") | |
| .getMember("PooledCockroachDatabase") | |
| .getASubclass*() | |
| result = | |
| API::moduleImport("playhouse") | |
| .getMember("cockroachdb") | |
| .getMember(["CockroachDatabase", "PooledCockroachDatabase"]) | |
| .getASubclass*() |
Member
Author
There was a problem hiding this comment.
As highlighted by the comment above, these are semi auto generated, so I don't think it's worth it to go through this trouble.
Co-authored-by: yoff <lerchedahl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.