Java: Fix CSV subtype interpretation #6215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should the change to |
Contributor
Author
Unless it's important to keep the two synced up, then I'd say no - it would just test the same thing twice. |
Contributor
|
It isn't important, from a technical point of view. But it would probably be less confusing to people looking at them in future if we keep them synced up. |
Contributor
javaGenerated file changes for java
- Others,"``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.databind``, ``com.unboundid.ldap.sdk``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.dom4j``, ``org.hibernate``, ``org.jooq``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``",7,8,82,,,,14,18,,
+ Others,"``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.databind``, ``com.unboundid.ldap.sdk``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.dom4j``, ``org.hibernate``, ``org.jooq``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``",7,12,82,,,,14,18,,
- Totals,,84,2013,287,13,6,6,98,33,1,66
+ Totals,,84,2017,287,13,6,6,98,33,1,66
- org.apache.commons.codec,,,2,,,,,,,,,,,,,,,2,
+ org.apache.commons.codec,,,6,,,,,,,,,,,,,,,6, |
smowton
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the interpretation of the subtypes/overrides csv column. Jumping to subtypes and matching members on the subtype doesn't make sense since generics mean that the signature might be different. As an example,
MultivaluedMap.puthas an (erased) signature that's different from the overriddenMap.putdue toVbeing instantiated toList<V>. The first two commits highlights this problem.The fix is to match the member on the supertype and jump to overrides of that member instead of matching the overriding member on the subtype.