Skip to content

Issue forms: set the "body" field as required#8430

Merged
hubwriter merged 2 commits intogithub:mainfrom
tomrav:patch-2
Jul 27, 2021
Merged

Issue forms: set the "body" field as required#8430
hubwriter merged 2 commits intogithub:mainfrom
tomrav:patch-2

Conversation

@tomrav
Copy link

@tomrav tomrav commented Jul 22, 2021

Why:

Found a mistake in the docs.

What's being changed:

In the documentation for the new "Issue Forms" the body field is marked as optional, it should be required.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jul 22, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 22, 2021
@ramyaparimi
Copy link
Contributor

@tomrav Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 22, 2021
@github github deleted a comment Jul 27, 2021
@github github deleted a comment Jul 27, 2021
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrav - Many thanks for fixing this. Much appreciated. 👍

@hubwriter hubwriter enabled auto-merge (squash) July 27, 2021 15:09
@hubwriter hubwriter merged commit 5cbca44 into github:main Jul 27, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@tomrav tomrav deleted the patch-2 branch July 28, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants