Skip to content

fix(@angular/cli): update engines to require node 12.20.0#20866

Merged
alan-agius4 merged 2 commits intoangular:masterfrom
alan-agius4:engines
Aug 9, 2021
Merged

fix(@angular/cli): update engines to require node 12.20.0#20866
alan-agius4 merged 2 commits intoangular:masterfrom
alan-agius4:engines

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented May 20, 2021 •
edited
Loading 

We drop support for Node.js versions prior to `12.20`.

@google-cla google-cla bot added the cla: yes label May 20, 2021
@alan-agius4 alan-agius4 requested a review from clydin May 20, 2021 10:29
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 20, 2021
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels May 20, 2021
@clydin clydin added the needs: discussion On the agenda for team meeting to determine next steps label May 20, 2021
@vladimiry vladimiry mentioned this pull request May 26, 2021
Closed
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed target: patch This PR is targeted for the next patch release needs: discussion On the agenda for team meeting to determine next steps labels Jun 3, 2021
@alan-agius4 alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Aug 4, 2021
@dgp1130 dgp1130 removed the needs: discussion On the agenda for team meeting to determine next steps label Aug 5, 2021
@alan-agius4 alan-agius4 added flag: breaking change and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 9, 2021
@alan-agius4 alan-agius4 requested a review from clydin August 9, 2021 12:29
@clydin
Copy link
Member

clydin commented Aug 9, 2021

We should also update this check as well:

angular-cli/packages/angular/cli/bin/ng

Line 32 in 3ba13f4

(version[0] === 12 && version[1] < 14) ||

@alan-agius4
fix(@angular/cli): update engines to require node 12.20.0
dccf42d 
BREAKING CHANGE:

We drop support for Node.js versions prior to `12.20`.
@alan-agius4
Revert "fix(@angular-devkit/build-angular): ensure Sass worker implem…
74203af 
…entation supports Node.js 12.14"

This reverts commit 4dc7cf9.
@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Aug 9, 2021

@clydin updated.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 9, 2021
@alan-agius4 alan-agius4 merged commit 019614b into angular:master Aug 9, 2021
@alan-agius4 alan-agius4 deleted the engines branch August 9, 2021 20:10
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker flag: breaking change target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @clydin @dgp1130