Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44771: Sync with importlib_resources 5.2.2, fixing refleak. #27497

Merged
merged 2 commits into from Jul 31, 2021
Merged

bpo-44771: Sync with importlib_resources 5.2.2, fixing refleak. #27497

merged 2 commits into from Jul 31, 2021

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Jul 30, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44771
@jaraco
bpo-44771: Sync with importlib_resources 5.2.2, fixing refleak.
108d5cf
@jaraco jaraco mentioned this pull request Jul 30, 2021
Merged
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

🤖 New build scheduled with the buildbot fleet by @jaraco for commit 108d5cf 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
@jaraco
Copy link
Member Author

@jaraco jaraco commented Jul 30, 2021

The test failure on buildbot/s390x Fedora Clang Installer PR seems spurious. That package clearly does exist. Does a new package need to be referenced in the makefile or something?
@jaraco
Include new 'resources' dir in the Makefile.
c0076d1
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

🤖 New build scheduled with the buildbot fleet by @jaraco for commit c0076d1 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
@jaraco
Copy link
Member Author

@jaraco jaraco commented Jul 30, 2021

The test failure on buildbot/s390x Fedora Clang Installer PR seems spurious. That package clearly does exist. Does a new package need to be referenced in the makefile or something?

On further consideration, this isn't spurious and is probably another class of buildbot failures missed in #27436, presumed fixed in c0076d1.
@jaraco
Copy link
Member Author

@jaraco jaraco commented Jul 30, 2021

The reported failure looks unrelated to these changes:

..python: Objects/dictobject.c:350: dictkeys_set_index: Assertion `keys->dk_version == 0' failed.
Fatal Python error: Aborted
Current thread 0x00007feb08ad2740 (most recent call first):
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/test_importlib/test_api.py", line 290 in test_reload_location_changed
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/case.py", line 592 in run
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/runner.py", line 176 in run
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/support/__init__.py", line 979 in _run_suite
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/support/__init__.py", line 1104 in run_unittest
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 261 in _test_module
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/refleak.py", line 90 in dash_R
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 295 in _runtest_inner2
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 335 in _runtest_inner
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 215 in _runtest
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 245 in runtest
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 334 in rerun_failed_tests
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 712 in _main
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 655 in main
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 733 in main
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/runpy.py", line 86 in _run_code
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/runpy.py", line 196 in _run_module_as_main
Extension modules: _testmultiphase (total: 1)
make: *** [buildbottest] Aborted
program finished with exit code 2
elapsedTime=2769.004730
test_reload_location_changed (test.test_importlib.test_api.Source_ReloadTests) ...
@jaraco jaraco merged commit e63e631 into main Jul 31, 2021
39 of 40 checks passed
39 of 40 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
@bedevere-bot
buildbot/AMD64 RHEL7 Refleaks PR Build done.
Details
Azure Pipelines PR #20210730.50 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44771 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@bedevere-bot
buildbot/AMD64 Debian PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Debian root PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable Clang Installed PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable Clang PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable Refleaks PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Ubuntu Shared PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows10 Pro PR Build done.
Details
@bedevere-bot
buildbot/PPC64 Fedora PR Build done.
Details
@bedevere-bot
buildbot/s390x Debian PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora Clang Installed PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora Clang PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora LTO PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora Refleaks PR Build done.
Details
@bedevere-bot
buildbot/s390x SLES PR Build done.
Details
@jaraco jaraco deleted the bpo-44771/resources-522 branch Jul 31, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 31, 2021

@jaraco: Please replace # with GH- in the commit message next time. Thanks!
This was referenced Jul 31, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@jaraco @bedevere-bot @the-knights-who-say-ni