Random anime character info #4553

ashish-patwal · 2021-07-18T15:10:37Z

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2021-07-18T15:10:41Z

random_anime_character.py

+URL = "https://www.mywaifulist.moe/random"
+
+
+def save_image(image_url: str, image_title: str) -> None:


As there is no test file in this pull request nor any test function or class in the file random_anime_character.py, please provide doctest for the function save_image

algorithms-keeper · 2021-07-18T15:10:41Z

random_anime_character.py

+        file.write(image.content)
+
+
+def random_anime_character() -> None:


As there is no test file in this pull request nor any test function or class in the file random_anime_character.py, please provide doctest for the function random_anime_character

algorithms-keeper · 2021-07-18T15:10:41Z

web_programming/random_anime_character.py

+URL = "https://www.mywaifulist.moe/random"
+
+
+def save_image(image_url: str, image_title: str) -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

algorithms-keeper · 2021-07-18T15:10:41Z

web_programming/random_anime_character.py

+        file.write(image.content)
+
+
+def random_anime_character() -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

As this script produces a random string of characters and info , i cannot presume and assert any conditions for the test . Thus doctests were not included .

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2021-07-18T16:00:04Z

web_programming/random_anime_character.py

+URL = "https://www.mywaifulist.moe/random"
+
+
+def save_image(image_url: str, image_title: str) -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

algorithms-keeper · 2021-07-18T16:00:04Z

web_programming/random_anime_character.py

+        file.write(image.content)
+
+
+def random_anime_character() -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

ashish-patwal · 2021-07-18T16:01:40Z

updates : black formatted the file as well as did pre-commit .
ptal @cclauss

cclauss · 2021-07-18T16:47:13Z

Run mypy .

web_programming/random_anime_character.py:38: error: No return value expected
web_programming/random_anime_character.py:42: error: "random_anime_character" does not return a value
Found 2 errors in 1 file (checked 316 source files)

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2021-07-19T05:37:36Z

web_programming/random_anime_character.py

+URL = "https://www.mywaifulist.moe/random"
+
+
+def save_image(image_url: str, image_title: str) -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

algorithms-keeper · 2021-07-19T05:37:36Z

web_programming/random_anime_character.py

+    return None
+
+
+def random_anime_character() -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

ashish-patwal · 2021-07-19T05:49:05Z

I did all the tests and the script passed all of them . pre-commit , black formatting , flake8 . Can you please take one more look @cclauss . Doctests can't be created for this script therefore ommitted .

cclauss

Please fix type hints until mypy passes.

web_programming/random_anime_character.py

Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2021-07-19T10:07:08Z

web_programming/random_anime_character.py

+URL = "https://www.mywaifulist.moe/random"
+
+
+def save_image(image_url: str, image_title: str) -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

algorithms-keeper · 2021-07-19T10:07:08Z

web_programming/random_anime_character.py

+    return None
+
+
+def random_anime_character() -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2021-07-19T10:07:24Z

web_programming/random_anime_character.py

+URL = "https://www.mywaifulist.moe/random"
+
+
+def save_image(image_url: str, image_title: str) -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

algorithms-keeper · 2021-07-19T10:07:24Z

web_programming/random_anime_character.py

+    return None
+
+
+def random_anime_character() -> tuple[str, str, str]:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

cclauss · 2021-07-19T15:33:11Z

web_programming/random_anime_character.py

+
+    return None


Suggested change

return None

This can safely be deleted. We would only use return None on functions that could return other values.

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2021-07-19T15:34:51Z

web_programming/random_anime_character.py

+URL = "https://www.mywaifulist.moe/random"
+
+
+def save_image(image_url: str, image_title: str) -> None:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function save_image

algorithms-keeper · 2021-07-19T15:34:51Z

web_programming/random_anime_character.py

+        file.write(image.content)
+
+
+def random_anime_character() -> tuple[str, str, str]:


As there is no test file in this pull request nor any test function or class in the file web_programming/random_anime_character.py, please provide doctest for the function random_anime_character

cclauss

Looks good to me. Thanks for your persistence. Well done.

ashish-patwal · 2021-07-19T17:34:43Z

Looks good to me. Thanks for your persistence. Well done.

Thank you as well . I learnt a lot .

ashish-patwal added 2 commits Jul 18, 2021

fixed colons and spaces

29e6ebd

fixed colons and spaces

f7bdf5a

ashish-patwal requested a review from cclauss as a code owner Jul 18, 2021

algorithms-keeper bot added require tests awaiting reviews labels Jul 18, 2021

algorithms-keeper bot reviewed Jul 18, 2021

View changes

random anime character python script

9ac182f

algorithms-keeper bot reviewed Jul 18, 2021

View changes

algorithms-keeper bot added the tests are failing label Jul 18, 2021

TheAlgorithms deleted a comment from ASHIKSAR Jul 18, 2021

more tests passed

4af41d6

algorithms-keeper bot reviewed Jul 19, 2021

View changes

cclauss requested changes Jul 19, 2021

View changes

web_programming/random_anime_character.py Outdated Show resolved Hide resolved

web_programming/random_anime_character.py Outdated Show resolved Hide resolved

algorithms-keeper bot added awaiting changes and removed awaiting reviews labels Jul 19, 2021

type hint updated

0341083

Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeper bot reviewed Jul 19, 2021

View changes

algorithms-keeper bot added awaiting reviews and removed awaiting changes labels Jul 19, 2021

type hint updated again

5375cba

Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeper bot reviewed Jul 19, 2021

View changes

ashish-patwal requested a review from cclauss Jul 19, 2021

cclauss reviewed Jul 19, 2021

View changes

Update random_anime_character.py

f7b7da1

algorithms-keeper bot reviewed Jul 19, 2021

View changes

cclauss approved these changes Jul 19, 2021

View changes

algorithms-keeper bot removed the awaiting reviews label Jul 19, 2021

algorithms-keeper bot removed the tests are failing label Jul 19, 2021

cclauss merged commit eca37b1 into TheAlgorithms:master Jul 19, 2021
2 checks passed

2 checks passed

build
Details

pre-commit
Details

ashish-patwal deleted the ashish-patwal:random_anime branch Jul 19, 2021

ashish-patwal restored the ashish-patwal:random_anime branch Jul 19, 2021

ashish-patwal deleted the ashish-patwal:random_anime branch Jul 19, 2021

ashish-patwal restored the ashish-patwal:random_anime branch Jul 19, 2021

		URL = "https://www.mywaifulist.moe/random"


		def save_image(image_url: str, image_title: str) -> None:

		file.write(image.content)


		def random_anime_character() -> None:

		return None


		def random_anime_character() -> tuple[str, str, str]:

TheAlgorithms / Python

Sponsor TheAlgorithms/Python

Random anime character info #4553

Random anime character info #4553

Conversation

ashish-patwal commented Jul 18, 2021

Describe your change:

Checklist:

algorithms-keeper bot left a comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

This comment has been minimized.

algorithms-keeper bot Jul 18, 2021

This comment has been minimized.

algorithms-keeper bot Jul 18, 2021

This comment has been minimized.

algorithms-keeper bot Jul 18, 2021

This comment has been minimized.

algorithms-keeper bot Jul 18, 2021

This comment has been minimized.

ashish-patwal Jul 18, 2021 Author Contributor

algorithms-keeper bot left a comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

This comment has been minimized.

algorithms-keeper bot Jul 18, 2021

This comment has been minimized.

algorithms-keeper bot Jul 18, 2021

ashish-patwal commented Jul 18, 2021

cclauss commented Jul 18, 2021

algorithms-keeper bot left a comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

ashish-patwal commented Jul 19, 2021

cclauss left a comment

algorithms-keeper bot left a comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

algorithms-keeper bot left a comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

This comment has been minimized.

cclauss Jul 19, 2021 Member

algorithms-keeper bot left a comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

This comment has been minimized.

algorithms-keeper bot Jul 19, 2021

ashish-patwal Jul 18, 2021
Author Contributor

cclauss Jul 19, 2021
Member