Added Marr-Hildreth edge detection algorithm #4640

gpapadok · 2021-08-19T21:37:42Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-08-19T21:38:00Z

digital_image_processing/edge_detection/marr_hildreth.py

+laplacian_kernel = np.array([[1, 1, 1], [1, -8, 1], [1, 1, 1]])
+
+
+def gaussian_kernel(sigma):


Please provide return type hint for the function: gaussian_kernel. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function gaussian_kernel

Please provide type hint for the parameter: sigma

ghost · 2021-08-19T21:38:00Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return kernel
+
+
+def zero_crossing(image, threshold=0):


Please provide return type hint for the function: zero_crossing. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function zero_crossing

Please provide type hint for the parameter: image

Please provide type hint for the parameter: threshold

ghost · 2021-08-19T21:38:00Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return edges
+
+
+def marr_hildreth(image, sigma=1, threshold=40):


Please provide return type hint for the function: marr_hildreth. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function marr_hildreth

Please provide type hint for the parameter: image

Please provide type hint for the parameter: sigma

Please provide type hint for the parameter: threshold

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-08-22T11:46:20Z

digital_image_processing/edge_detection/marr_hildreth.py

+laplacian_kernel = np.array([[1, 1, 1], [1, -8, 1], [1, 1, 1]])
+
+
+def gaussian_kernel(sigma):


Please provide return type hint for the function: gaussian_kernel. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function gaussian_kernel

Please provide type hint for the parameter: sigma

ghost · 2021-08-22T11:46:20Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return kernel
+
+
+def zero_crossing(image, threshold=0):


Please provide return type hint for the function: zero_crossing. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function zero_crossing

Please provide type hint for the parameter: image

Please provide type hint for the parameter: threshold

ghost · 2021-08-22T11:46:20Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return edges
+
+
+def marr_hildreth(image, sigma=1, threshold=40):


Please provide return type hint for the function: marr_hildreth. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function marr_hildreth

Please provide type hint for the parameter: image

Please provide type hint for the parameter: sigma

Please provide type hint for the parameter: threshold

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-08-22T12:09:33Z

digital_image_processing/edge_detection/marr_hildreth.py

+laplacian_kernel = np.array([[1, 1, 1], [1, -8, 1], [1, 1, 1]])
+
+
+def gaussian_kernel(sigma: float) -> np.ndarray:


As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function gaussian_kernel

ghost · 2021-08-22T12:09:34Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return kernel
+
+
+def zero_crossing(image: np.ndarray, threshold: float = 0) -> np.ndarray:


As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function zero_crossing

ghost · 2021-08-22T12:09:34Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return edges
+
+
+def marr_hildreth(


As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function marr_hildreth

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-08-22T14:12:57Z

digital_image_processing/edge_detection/marr_hildreth.py

+laplacian_kernel = np.array([[1, 1, 1], [1, -8, 1], [1, 1, 1]])
+
+
+def gaussian_kernel(sigma: float) -> np.ndarray:


As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function gaussian_kernel

ghost · 2021-08-22T14:12:57Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return kernel
+
+
+def zero_crossing(image: np.ndarray, threshold: float = 0) -> np.ndarray:


As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function zero_crossing

ghost · 2021-08-22T14:12:57Z

digital_image_processing/edge_detection/marr_hildreth.py

+    return edges
+
+
+def marr_hildreth(


As there is no test file in this pull request nor any test function or class in the file digital_image_processing/edge_detection/marr_hildreth.py, please provide doctest for the function marr_hildreth

add marr-hildreth edge detection algorithm

396d785

ghost added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Aug 19, 2021

ghost reviewed Aug 19, 2021

View reviewed changes

ghost reviewed Aug 22, 2021

View reviewed changes

ghost removed tests are failing Do not merge until tests pass require type hints https://docs.python.org/3/library/typing.html labels Aug 22, 2021

ghost reviewed Aug 22, 2021

View reviewed changes

ghost added tests are failing Do not merge until tests pass and removed require tests Tests [doctest/unittest/pytest] are required labels Aug 22, 2021

add type hints

41291e4

ghost added the require tests Tests [doctest/unittest/pytest] are required label Aug 22, 2021

ghost reviewed Aug 22, 2021

View reviewed changes

ghost removed the tests are failing Do not merge until tests pass label Aug 22, 2021

add doctests

da69bb2

ghost added tests are failing Do not merge until tests pass and removed require tests Tests [doctest/unittest/pytest] are required labels Aug 23, 2021

fix zero_crossing function and doctests

edbcc14

ghost removed the tests are failing Do not merge until tests pass label Aug 23, 2021

rename file

ad99432

gpapadok changed the title ~~add marr-hildreth edge detection algorithm~~ Added Marr-Hildreth edge detection algorithm Aug 23, 2021

gpapadok closed this Sep 17, 2021

gpapadok deleted the add-marr-hildreth branch September 17, 2021 15:11

		laplacian_kernel = np.array([[1, 1, 1], [1, -8, 1], [1, 1, 1]])


		def gaussian_kernel(sigma):

		return edges


		def marr_hildreth(image, sigma=1, threshold=40):

		laplacian_kernel = np.array([[1, 1, 1], [1, -8, 1], [1, 1, 1]])


		def gaussian_kernel(sigma: float) -> np.ndarray:

		return kernel


		def zero_crossing(image: np.ndarray, threshold: float = 0) -> np.ndarray:

Uh oh!

Added Marr-Hildreth edge detection algorithm #4640

Added Marr-Hildreth edge detection algorithm #4640

Uh oh!

Conversation

gpapadok commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gpapadok commented Aug 19, 2021 •

edited

Loading