-
Notifications
You must be signed in to change notification settings - Fork 219
Graph view for @kind graph queries
#705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d483bab to
41a3785
Compare
|
@hvitved what is your plan for this PR? Are you using this yourself? It is a great idea, but I don't have the bandwidth to publicly release this. With a little bit of work, we can probably release this behind a feature flag. |
My plan was to keep this branch alive until we have proper support. Yes, I use it myself. |
|
Thanks for the update. When I get a chance, I'll work on it to release it behind a feature flag. |
|
Thanks @aeisenberg, that would be very useful. But please don't use the code in this branch as-is; there are many (or at least some) cases of "we have no idea what we are doing" :-) |
319dd03 to
ce6cd36
Compare
ce6cd36 to
a2d33f2
Compare
a2d33f2 to
f01b1fc
Compare
bd155ab to
9dd3451
Compare
5177cbe to
fbfe9a8
Compare
|
This has been invaluable for me in my recent work debugging a QL regex parser, although it does get quite unwieldy with large graphs. Something more interactive that lets you collapse subtrees would be amazing. If this does become the basis for a released feature, I should note that I've found a few issues:
|
03d16ee to
9f2ef00
Compare
001896a to
ca77791
Compare
ca77791 to
b3c07e2
Compare
b3c07e2 to
86ad79b
Compare
86ad79b to
eb0a72f
Compare
|
I hope to get a chance to look at this next week. I'll be putting this feature behind the canary flag, so we won't advertise it widely. I'm planning on largely using what this PR as-is since it's shown to be useful already. Thanks again for putting this up and apologies it's taken over a year to look at this. |
|
Superseded by #1111 |

DO NOT MERGE
This is a prototype implementation of graph visualization in the extension (implemented in collaboration with @AlonaHlobina and @aibaars). It works for queries marked as
@kind graph, and we also implemented a 'View CFG' command that executes the query with IDide-contextual-queries/print-cfg(if it exists).This PR is not meant to be merged, but rather it can be used as inspiration for a "real" implementation. Until we have an official implementation, I plan to use the artifacts created via this PR.