Python: model os path file accesses #6741
Open
Conversation
RasmusWL
requested changes
Sep 27, 2021
There are a few more functions that could reveal information about the file system, by telling the last modification time of a file, e.g.
getmtime. This will raise an error if the file does not exist, so could also reveal the existence of files depending on the applications error handling. These are currently not included.
Can we please model these as well? they fit the FileSystemAccess concept as far as I can tell.
on non-existing files.
RasmusWL
reviewed
Sep 30, 2021
| "getatime", "getmtime", "getctime", "getsize", | ||
| // this will resolve symlinks | ||
| "realpath" |
As we discussed in meeting, let's handle realpath with an extra taint-step instead.
Suggested change
| "getatime", "getmtime", "getctime", "getsize", | |
| // this will resolve symlinks | |
| "realpath" | |
| "getatime", "getmtime", "getctime", "getsize" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR includes a number of functions in
os.pathinto the conceptFileSystemAccess. These all test for the existence of files in some way.There are a few more functions that could reveal information about the file system, by telling the last modification time of a file, e.g.
getmtime. This will raise an error if the file does not exist, so could also reveal the existence of files depending on the applications error handling. These are currently not included.The text was updated successfully, but these errors were encountered: