Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows #27168

Merged
merged 2 commits into from Jul 23, 2021
Merged

bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows #27168

merged 2 commits into from Jul 23, 2021
+19 −41

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Jul 15, 2021 •
edited

https://bugs.python.org/issue44611

FYI, this patch is written at Microsoft Azure system which I got the credits from Microsoft!
https://mail.python.org/archives/list/python-committers@python.org/message/LXXZ3F7MHCAULKYZADGAKZHE6FBLNZ62/
@corona10 corona10 requested a review from python/windows-team as a code owner Jul 15, 2021
@corona10
Copy link
Member Author

@corona10 corona10 commented Jul 15, 2021

Microsoft

CNG is supported beginning with Windows Server 2008 and Windows Vista

CPython

This means that Python 3.9 supports Windows 8.1 and newer. If you require Windows 7 support, please install Python 3.8.
@corona10 corona10 changed the title bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows [WIP] bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows Jul 15, 2021
@corona10 corona10 force-pushed the corona10:bpo-44611 branch 2 times, most recently from 0279db3 to 37660c6 Jul 15, 2021
@corona10
bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows
ac73b3b
@corona10 corona10 force-pushed the corona10:bpo-44611 branch from 37660c6 to ac73b3b Jul 15, 2021
@corona10 corona10 changed the title [WIP] bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows bpo-44611: Use BCryptGenRandom instead of CryptGenRandom on Windows Jul 15, 2021
@corona10 corona10 requested review from tim-one and zooba Jul 15, 2021
@corona10
bpo-44611: Reorder whatsnews
2c6f620
@corona10 corona10 force-pushed the corona10:bpo-44611 branch from 619053b to 2c6f620 Jul 15, 2021
@zooba
zooba approved these changes Jul 15, 2021
View changes
@corona10
Copy link
Member Author

@corona10 corona10 commented Jul 16, 2021 •
edited

I am now waiting for @tim-one 's review.
(I will merge after review)
@corona10
Copy link
Member Author

@corona10 corona10 commented Jul 23, 2021 

PS C:\Users\corona10\cpython> PCbuild\amd64\python_d.exe -m test test_random -R 3:3
0:00:00 Run tests sequentially
0:00:00 [1/1] test_random
beginning 6 repetitions
123456
......

I checked the memory is not leaked with this patch :)
@corona10 corona10 merged commit 906fe47 into python:main Jul 23, 2021
13 checks passed
13 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210715.50 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44611 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@corona10 corona10 deleted the corona10:bpo-44611 branch Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

@tim-one tim-one

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@corona10 @zooba @the-knights-who-say-ni @bedevere-bot