Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: translation errrors #940

Merged
merged 4 commits into from Oct 5, 2021
Merged

Fix: translation errrors #940

merged 4 commits into from Oct 5, 2021

Conversation

Copy link
Contributor

@uknfire uknfire commented Aug 20, 2021

目标章节

  • 2-ui/5-loading/01-onload-ondomcontentloaded/article.md
  • 2-ui/2-events/01-introduction-browser-events/04-move-ball-field/task.md
  • 5-network/06-fetch-api/article.md
  • 6-data-storage/01-cookie/article.md

当前上游最新 commitjavascript-tutorial/en.javascript.info@4d01fc2

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
2-ui/5-loading/01-onload-ondomcontentloaded/article.md 修改翻译错误
2-ui/2-events/01-introduction-browser-events/04-move-ball-field/task.md 修改翻译错误
5-network/06-fetch-api/article.md 修改翻译错误
6-data-storage/01-cookie/article.md 改进翻译

uknfire added 4 commits Aug 14, 2021
…aded/article.md

original text: What happens if we set the DOMContentLoaded handler after the document is loaded?
…vents/04-move-ball-field/task.md

original text: When the page is scrolled, nothing should break.
original text: The keepalive option indicates that the request may “outlive” the webpage that initiated it.
"outlive" means live longer than ...
original text: 1. A samesite=lax cookie is sent if both of these conditions are true 2.So, what samesite=lax does, is to basically allow the most common “go to URL” operation to have cookies. E.g. opening a website link from notes that satisfy these conditions.
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@leviding leviding left a comment

Thanks.

@leviding leviding merged commit ecb2c8d into javascript-tutorial:master Oct 5, 2021
1 check passed
@leviding leviding added DONE and removed needs +1 labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants