Skip to content

JS: [Internal only] Add experimental libraries and queries for adaptive threat modeling#6907

Merged
henrymercer merged 2 commits intomainfrom
henrymercer/add-experimental-atm-libraries
Oct 22, 2021
Merged

JS: [Internal only] Add experimental libraries and queries for adaptive threat modeling#6907
henrymercer merged 2 commits intomainfrom
henrymercer/add-experimental-atm-libraries

Conversation

@henrymercer
Copy link
Contributor

This PR adds experimental queries and libraries for adaptive threat modeling to new experimental query and library packs located at javascript/ql/experimental/adaptivethreatmodeling/src and javascript/ql/experimental/adaptivethreatmodeling/lib respectively. These queries and libraries are for internal use only; queries will produce no results for external users and APIs may change in the future. It is also likely that the naming for this feature will change. The standard analysis and standard JavaScript packs are unaffected by this change.

Tests are currently run internally. Subsequent PRs will move some of these tests into the public repository.

Questions for review:

  • These libraries should probably not be incorporated into the QLDoc coverage statistics. How do we make sure they're excluded?

@henrymercer henrymercer added JS no-change-note-required This PR does not need a change note labels Oct 18, 2021
@henrymercer henrymercer requested review from a team October 18, 2021 15:31
@henrymercer henrymercer force-pushed the henrymercer/add-experimental-atm-libraries branch from afb91e1 to 4d7a828 Compare October 18, 2021 16:24
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally sensible.

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from JS perspective

@henrymercer henrymercer merged commit 02b1fe2 into main Oct 22, 2021
@henrymercer henrymercer deleted the henrymercer/add-experimental-atm-libraries branch October 22, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation JS no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants