Python: Type tracker changes #6858
Open
Conversation
tausbn
approved these changes
Oct 25, 2021
One minor suggestion, otherwise LGTM.
| */ | ||
| TypeTracker getACompatibleTypeTracker() { | ||
| exists(boolean hasCall | result = MkTypeTracker(hasCall, content) | | ||
| hasCall = false or hasReturn() = false |
Suggested change
| hasCall = false or hasReturn() = false | |
| hasCall = false or this.hasReturn() = false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The first commit caches
TypeBackTracker::prepend, similar to howTypeTracker::appendis cached.The second commit introduces a new predicate
TypeBackTracker::getACompatibleTypeTracker(), which is useful when reasoning about nodes that can be reached in both forwards tracking and backwards tracking.The text was updated successfully, but these errors were encountered: