TheAlgorithms / Python Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mypy] annotate compression
#5570
Conversation
3e2585d
to
4299195
| self.bitstring = {} | ||
| def __init__(self, letter: str, freq: int): | ||
| self.letter: str = letter | ||
| self.freq: int = freq |
Are Python and mypy smart enough to know the data types being assigned on lines 8 and 9? Even without the type hint, won’t mypy still complain if I later try to assign 1 to self.letter or “A” to self.freq?
I think you are being rhetoric here
You and I agree with each other. The most helpful use of type hints is in function parameters and return types.
| @@ -75,10 +82,11 @@ def bwt_transform(s: str) -> dict: | |||
| rotations = all_rotations(s) | |||
| rotations.sort() # sort the list of rotations in alphabetically order | |||
| # make a string composed of the last char of each rotation | |||
| return { | |||
| response: BWTTransformDict = { | |||
Does this change run counter to flake8 return error R504? https://github.com/afonasev/flake8-return#errors
Describe your change:
Fixed missing type annotation for compression directory. It now passes
mypy --strict.Related to #4052
Checklist:
Fixes: #{$ISSUE_NO}.The text was updated successfully, but these errors were encountered: