Skip to content

#1401 add junit-jupiter-api#1403

Merged
wumpz merged 1 commit intoJSQLParser:masterfrom
gitmotte:#1401
Nov 19, 2021
Merged

#1401 add junit-jupiter-api#1403
wumpz merged 1 commit intoJSQLParser:masterfrom
gitmotte:#1401

Conversation

@gitmotte
Copy link
Contributor

@gitmotte gitmotte commented Nov 4, 2021

@wumpz
Copy link
Member

wumpz commented Nov 19, 2021

So you are simply replacing this jar which is using the vintage engine to run the junit 4 tests we have now? Or are you going to replace all annotations and used classes to the jupiter version?

@gitmotte
Copy link
Contributor Author

Not at all, this is just a bugfix for a missing dependency in Maven's pom.xml
Please have a look at this comment #1401 (comment)

@wumpz
Copy link
Member

wumpz commented Nov 19, 2021

Sorry. I see that within some of the former PRs there was this change so JSqlParser now indeed uses some kind of mixture.

@wumpz wumpz merged commit 80ff50e into JSQLParser:master Nov 19, 2021
@wumpz
Copy link
Member

wumpz commented Nov 19, 2021

However, I will change the import to be proper for this case.

@manticore-projects
Copy link
Contributor

The JUnit 5 dependency was brought in by me for allowing parallel tests with Gradle. Forgetting to add it to Maven was an oversight. (I never liked Maven and jumped from ANT to GRADLE directly).

That said, I think it would make sense to migrate to JUnit 5 and to drop JUnit 4 eventually.

@wumpz
Copy link
Member

wumpz commented Nov 20, 2021

No problem here. I had the same problematic in diff rent other projects. You have to check that your tests are running. If wrongly configured,. Junjt 4 or 5 tests are skipped.

However, with this knowledge I consider this my problem, since I did not see the chance before.

@wumpz
Copy link
Member

wumpz commented Nov 21, 2021

Look into #1427.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants