Skip to content

bpo-28953: Use raise from when raising new IncompleteRead#29861

Merged
miss-islington merged 2 commits intopython:mainfrom
180909:fix-issue28953
Dec 7, 2021
Merged

bpo-28953: Use raise from when raising new IncompleteRead#29861
miss-islington merged 2 commits intopython:mainfrom
180909:fix-issue28953

Conversation

@180909
Copy link
Copy Markdown
Contributor

@180909 180909 commented Nov 30, 2021

@cool-RR
Copy link
Copy Markdown
Contributor

cool-RR commented Nov 30, 2021

Thank you Jiahua!

@cool-RR
Copy link
Copy Markdown
Contributor

cool-RR commented Dec 4, 2021

@180909 Please edit the PR's title, it's bad. You could change it to "bpo-28953: Use raise from when raising new IncompleteRead" or anything else that makes sense.

@cool-RR
Copy link
Copy Markdown
Contributor

cool-RR commented Dec 4, 2021

Also, for the core developer who's going to review this: Please add the "skip news" label.

@180909 180909 changed the title bpo-28953: Use when raising new IncompleteRead bpo-28953: Use raise from when raising new IncompleteRead Dec 5, 2021
@180909 180909 changed the title bpo-28953: Use raise from when raising new IncompleteRead bpo-28953: Use raise from when raising new IncompleteRead Dec 5, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

@180909: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c5c3652 into python:main Dec 7, 2021
@asvetlov
Copy link
Copy Markdown
Contributor

asvetlov commented Dec 7, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants