Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42972: Fully implement GC protocol for xxlimited.Xxo #26451

Merged
merged 1 commit into from May 31, 2021
Merged

bpo-42972: Fully implement GC protocol for xxlimited.Xxo #26451

merged 1 commit into from May 31, 2021

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented May 29, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue42972
@shihai1991
Copy link
Member Author

@shihai1991 shihai1991 commented May 29, 2021

@vstinner @pablogsal Hi, victor, pablo. Do we need update this xxlimited template too?

@shihai1991 shihai1991 requested review from vstinner and pablogsal May 29, 2021
@vstinner vstinner merged commit 4b20f25 into python:main May 31, 2021
11 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 31, 2021

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 31, 2021

GH-26460 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue May 31, 2021
@shihai1991 @miss-islington
bpo-42972: Fully implement GC protocol for xxlimited (pythonGH-26451)
2b97e9c 
(cherry picked from commit 4b20f25)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@vstinner
Copy link
Member

@vstinner vstinner commented May 31, 2021

Merged, thanks.

@shihai1991
Copy link
Member Author

@shihai1991 shihai1991 commented May 31, 2021

Merged, thanks.

Thanks, victor :)

pablogsal pushed a commit that referenced this issue May 31, 2021
@shihai1991 @miss-islington
bpo-42972: Fully implement GC protocol for xxlimited (GH-26451) (GH-2…
f097d23 
…6460)

(cherry picked from commit 4b20f25)

Co-authored-by: Hai Shi <shihai1992@gmail.com>

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@shihai1991 @JuniorJPDJ
bpo-42972: Fully implement GC protocol for xxlimited (pythonGH-26451)
5ce130b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@shihai1991 @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni