bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467) #29467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Heimes <christian@python.org>
erlend-aasland
reviewed
Nov 9, 2021
I left some comments about configure.ac (I haven't looked at the setup.py changes yet)
| AC_CHECK_LIB([ndbm], [dbm_open]) | ||
| LIBS="$LIBS_SAVE" | ||
| AC_CHECK_LIB([gdbm_compat], [dbm_open]) |
There was a problem hiding this comment.
I wonder if we can fold these into:
Suggested change
| AC_CHECK_LIB([ndbm], [dbm_open]) | |
| LIBS="$LIBS_SAVE" | |
| AC_CHECK_LIB([gdbm_compat], [dbm_open]) | |
| AC_SEARCH_LIBS([dbm_open], [ndbm gdbm_compat]) |
There was a problem hiding this comment.
AC_SEARCH_LIBS() does not create HAVE_LIBFOO entries.
There was a problem hiding this comment.
Ah, that's unfortunate.
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland
approved these changes
Nov 10, 2021
LGTM. Is it worth it to document the USE_* defines in whatsnew?
It's an internal detailed of the build system and not user-facing. |
remykarem
pushed a commit
to remykarem/cpython
that referenced
this issue
Dec 7, 2021
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
remykarem
pushed a commit
to remykarem/cpython
that referenced
this issue
Jan 30, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45747