-
-
Notifications
You must be signed in to change notification settings - Fork 49.9k
Add missing type annotations in matrix directory
#5824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
matrixmatrix directory
poyea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!🤩
poyea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can fix these as well?
count_islands_in_matrix.py:110: error: Missing type parameters for generic type "list"
count_islands_in_matrix.py:131: error: Missing type parameters for generic type "list"
count_islands_in_matrix.py:163: error: Returning Any from function declared to return "int"
count_islands_in_matrix.py:165: error: Returning Any from function declared to return "int"
count_islands_in_matrix.py:248: error: Missing type parameters for generic type "list"
count_islands_in_matrix.py:264: error: Missing type parameters for generic type "list"
count_islands_in_matrix.py:356: error: Missing type parameters for generic type "list"
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.