Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: 1-js/07-object-properties/02-property-accessors/article.md #993

Merged
merged 1 commit into from Feb 4, 2022
Merged

imp: 1-js/07-object-properties/02-property-accessors/article.md #993

merged 1 commit into from Feb 4, 2022

Conversation

Dangdtx
Copy link
Contributor

@Dangdtx Dangdtx commented Jan 14, 2022

Getter ----->getter

目标章节：例如 1-js/01-getting-started/1-intro

当前上游最新 commit：此处填写本项目英文版 https://github.com/javascript-tutorial/en.javascript.info 的最新 commit，例如 b03ca00

**本 PR 所做更改如下：Getter ----->getter 将Getter修改为getter

文件名 参考上游 commit 更改（理由）
article.md a23882d 修改部分错误

注意，参考上游 commit 是指你所修改的文件，在英文仓库中同名文件的对应 commit，即你此次提交的修改的依据。如果本 PR 你只是提交一个文字或者语句优化，并非根据上游英文仓库的修改而提交的更新，则请填无。

@Dangdtx
Update article.md
081503c 
Getter ----->getter
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jan 14, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

songhn233
songhn233 reviewed Jan 14, 2022
View changes
Copy link
Member

@songhn233 songhn233 left a comment

这里为什么要修改成小写呢

@Dangdtx
Copy link
Contributor Author

@Dangdtx Dangdtx commented Jan 16, 2022

这里为什么要修改成小写呢

外文网站首字母大写 翻译到中文网站不应该入乡随俗么 会不会有一定的歧义 属性访问器是Getter

@songhn233
Copy link
Member

@songhn233 songhn233 commented Jan 16, 2022

外文网站首字母大写 翻译到中文网站不应该入乡随俗么 会不会有一定的歧义 属性访问器是Getter

大写的 Getter 会造成歧义嘛，能否详细一点。

看了下 MDN 的中文翻译也有 类似的。我理解如果这个大小写需要去修改的话整个教程其他地方的类似场景都需要一起修改？

@leviding
Copy link
Member

@leviding leviding commented Feb 4, 2022

我认为这里改不改都无伤大雅，提了就改了吧

@leviding leviding changed the title Update article.md fix: 1-js/07-object-properties/02-property-accessors/article.md Feb 4, 2022
@leviding leviding changed the title fix: 1-js/07-object-properties/02-property-accessors/article.md imp: 1-js/07-object-properties/02-property-accessors/article.md Feb 4, 2022
@leviding leviding merged commit 6b2e887 into javascript-tutorial:master Feb 4, 2022
1 check passed
@leviding leviding added DONE and removed needs +1 labels Feb 4, 2022
@Dangdtx Dangdtx deleted the patch-1 branch Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songhn233 songhn233

@leviding leviding

Assignees
No one assigned
Labels
DONE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dangdtx @CLAassistant @songhn233 @leviding @javascript-translate-bot