Ruby: Introduce TAnyArrayElementContent
#7726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmac
approved these changes
Jan 26, 2022
Contributor
hmac
left a comment
There was a problem hiding this comment.
Am I right in thinking that we let array indices range from 0..10? Then it looks like the problem is even worse than you describe, as we'd get 12^3 SummaryComponentStacks for dig(x,y,z) (the 12th being TUnknownArrayElementContent)!
Contributor
Author
Correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids potential combinatorial explosion in
SummaryComponentStacks. Until now it has not been a problem, since array indices are limited to0..5, but with this change we should be able to track arbitrary known indices.One example is the
digmethod, wheredig(x, y, z)(with unknownsx,y, andz) yields 6^3SummaryComponentStacks. With this change it yields just a singleSummaryComponentStack, regardless of whether we increase the precision of which indices to track.