Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-23556: Fix discrepancy in raise without argument; Apply patch from Bug Tracker #29236

Merged
merged 3 commits into from Jan 27, 2022
Merged

bpo-23556: Fix discrepancy in raise without argument; Apply patch from Bug Tracker #29236

merged 3 commits into from Jan 27, 2022

Conversation

kinshukdua
Copy link
Contributor

@kinshukdua kinshukdua commented Oct 27, 2021 •
edited by bedevere-bot

Apply Martin's patch for issues in raise in https://bugs.python.org/issue23556.
A couple of changes were already made in other PRs, those were skipped.

https://bugs.python.org/issue23556

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 27, 2021
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Oct 27, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@kinshukdua

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

github-actions bot commented Nov 28, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 28, 2021
@kinshukdua kinshukdua closed this Jan 7, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 7, 2022

Hi! I'm sorry your PR was open for so many months without being reviewed — was there a reason why you closed it, other than that? 🙂

@kinshukdua
Copy link
Contributor Author

kinshukdua commented Jan 26, 2022

@AlexWaygood Hi, sorry for closing the PR, I thought the PR wouldn't be reviewed anymore after being marked stale that's why I closed it.

@kinshukdua kinshukdua reopened this Jan 26, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 26, 2022

@AlexWaygood Hi, sorry for closing the PR, I thought the PR wouldn't be reviewed anymore after being marked stale that's why I closed it.

Not necessarily :) CPython is largely run by volunteers, so unfortunately it can often take a while until PRs get reviewed.

@AlexWaygood AlexWaygood removed the stale Stale PR or inactive for long period of time. label Jan 26, 2022
@AlexWaygood AlexWaygood requested a review from iritkatriel Jan 26, 2022
@kinshukdua
Copy link
Contributor Author

kinshukdua commented Jan 26, 2022

@AlexWaygood I'll keep that in mind when I contribute in the future!

iritkatriel
iritkatriel reviewed Jan 26, 2022
View changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Thank you for the PR. I made a few suggestions. Note that you can accept them via the API if you want, by clicking the relevant button.

Doc/library/exceptions.rst Outdated Show resolved Hide resolved
Doc/library/exceptions.rst Outdated Show resolved Hide resolved
Doc/library/exceptions.rst Outdated Show resolved Hide resolved
Doc/reference/simple_stmts.rst Outdated Show resolved Hide resolved
@kinshukdua @iritkatriel
Apply suggestions
b085ef7 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel
iritkatriel approved these changes Jan 27, 2022
View changes
Doc/library/exceptions.rst Outdated Show resolved Hide resolved
@iritkatriel iritkatriel merged commit 08c0ed2 into python:main Jan 27, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 27, 2022

Thanks @kinshukdua for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jan 27, 2022

GH-30953 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2022
@kinshukdua @miss-islington
bpo-23556: [doc] Fix inaccuracy in documentation for raise without ar…
74ef16d 
…gs. Improve tests for context in nested except handlers. (pythonGH-29236)

(cherry picked from commit 08c0ed2)

Co-authored-by: Kinshuk Dua <kinshukdua@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2022
@kinshukdua @miss-islington
bpo-23556: [doc] Fix inaccuracy in documentation for raise without ar…
f962302 
…gs. Improve tests for context in nested except handlers. (pythonGH-29236)

(cherry picked from commit 08c0ed2)

Co-authored-by: Kinshuk Dua <kinshukdua@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 27, 2022

GH-30954 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jan 27, 2022
@miss-islington @kinshukdua
bpo-23556: [doc] Fix inaccuracy in documentation for raise without ar…
1440dd3 
…gs. Improve tests for context in nested except handlers. (GH-29236)

(cherry picked from commit 08c0ed2)

Co-authored-by: Kinshuk Dua <kinshukdua@gmail.com>
miss-islington added a commit that referenced this pull request Jan 27, 2022
@miss-islington
[3.10] bpo-23556: [doc] Fix inaccuracy in documentation for raise wit…
2572c67 
…hout args. Improve tests for context in nested except handlers. (GH-29236) (GH-30953)

(cherry picked from commit 08c0ed2)


Co-authored-by: Kinshuk Dua <kinshukdua@gmail.com>

Automerge-Triggered-By: GH:iritkatriel
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @kinshukdua @hello-adam
bpo-23556: [doc] Fix inaccuracy in documentation for raise without ar…
5c31d04 
…gs. Improve tests for context in nested except handlers. (pythonGH-29236)

(cherry picked from commit 08c0ed2)

Co-authored-by: Kinshuk Dua <kinshukdua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kinshukdua @the-knights-who-say-ni @AlexWaygood @miss-islington @bedevere-bot @iritkatriel