ADD A5/1 Algorithm #5926

nirbhay12345 · 2022-01-16T13:28:58Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2022-01-16T13:29:09Z

ciphers/a51.py

+tapped_bits_2:list = [20,21]
+tapped_bits_3:list = [7,20,21,22]
+
+def set_register(type:int, i:int, a:str):


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function set_register

Please provide return type hint for the function: set_register. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: i

Please provide descriptive name for the parameter: a

ghost · 2022-01-16T13:29:09Z

ciphers/a51.py

+        if i < 23:
+            LFSR3[i] = intermediate_xor ^ int(a)
+
+def majority(arr:list):


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function majority

Please provide return type hint for the function: majority. If the function does not return a value, please provide the type hint as: def function() -> None:

ghost · 2022-01-16T13:29:09Z

ciphers/a51.py

+        if(val > 1):
+            return key
+
+def set_register_majority(mv:int):


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function set_register_majority

Please provide return type hint for the function: set_register_majority. If the function does not return a value, please provide the type hint as: def function() -> None:

ghost · 2022-01-16T13:29:09Z

ciphers/a51.py

+        LFSR3.insert(0, intermediate_xor)
+        LFSR3.pop()
+
+def main():


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function main

Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2022-01-16T13:34:40Z

ciphers/a51.py

+tapped_bits_2:list = [20,21]
+tapped_bits_3:list = [7,20,21,22]
+
+def set_register(type:int, i:int, a:str) -> None:


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function set_register

Please provide descriptive name for the parameter: i

Please provide descriptive name for the parameter: a

ghost · 2022-01-16T13:34:40Z

ciphers/a51.py

+        if i < 23:
+            LFSR3[i] = intermediate_xor ^ int(a)
+
+def majority(arr:list) -> None:


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function majority

ghost · 2022-01-16T13:34:40Z

ciphers/a51.py

+        if(val > 1):
+            return key
+
+def set_register_majority(mv:int) -> None:


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function set_register_majority

ghost · 2022-01-16T13:34:40Z

ciphers/a51.py

+        LFSR3.insert(0, intermediate_xor)
+        LFSR3.pop()
+
+def main() -> None:


As there is no test file in this pull request nor any test function or class in the file ciphers/a51.py, please provide doctest for the function main

We need more doctests

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2022-01-16T13:50:11Z

ciphers/a51.py

+tapped_bits_2:list = [20,21]
+tapped_bits_3:list = [7,20,21,22]
+
+def set_register(type:int, i:int, a:str) -> None:


Please provide descriptive name for the parameter: i

Please provide descriptive name for the parameter: a

nirbhay12345 · 2022-01-20T17:20:17Z

@poyea please review this PR

poyea · 2022-01-21T03:33:15Z

ciphers/a51.py

+    """
+    >>> set_register_majority(0)
+    """
+    if (majority_value == LFSR1[8]):


Suggested change

if (majority_value == LFSR1[8]):

if majority_value == LFSR1[8]:

poyea · 2022-01-21T03:33:58Z

ciphers/a51.py

+for _ in range(reg1_len):
+    LFSR1.append(0)
+for _ in range(reg2_len):
+    LFSR2.append(0)
+for _ in range(reg3_len):
+    LFSR3.append(0)
+


Use [0] * N?

okay working on this

stale · 2022-04-18T19:02:47Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cclauss · 2022-10-01T10:37:23Z

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that do not have passing tests.

nirbhay12345 added 6 commits January 15, 2022 21:35

ADD A5/1 FILE

a597eb3

set the registers

1d227b5

Implement Algo Fully

052ae65

improve code

2fc58ce

code refractor

c5aae48

refractor code

e25ac82

ghost added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jan 16, 2022

ghost reviewed Jan 16, 2022

View reviewed changes

ghost added the awaiting reviews This PR is ready to be reviewed label Jan 16, 2022

return Type added

1aaf5d7

ghost removed the require type hints https://docs.python.org/3/library/typing.html label Jan 16, 2022

ghost reviewed Jan 16, 2022

View reviewed changes

ADD doctest

abe001b

ghost removed the require tests Tests [doctest/unittest/pytest] are required label Jan 16, 2022

ghost reviewed Jan 16, 2022

View reviewed changes

ADD descriptive names

714286a

ghost removed the require descriptive names This PR needs descriptive function and/or variable names label Jan 16, 2022

poyea self-assigned this Jan 21, 2022

poyea reviewed Jan 21, 2022

View reviewed changes

ghost added the tests are failing Do not merge until tests pass label Jan 21, 2022

stale bot added the stale Used to mark an issue or pull request stale. label Apr 18, 2022

cclauss closed this Oct 1, 2022

	if (majority_value == LFSR1[8]):
	if majority_value == LFSR1[8]:

Uh oh!

ADD A5/1 Algorithm #5926

ADD A5/1 Algorithm #5926

Uh oh!

Conversation

nirbhay12345 commented Jan 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirbhay12345 commented Jan 20, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale bot commented Apr 18, 2022

Uh oh!

cclauss commented Oct 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nirbhay12345 commented Jan 16, 2022 •

edited

Loading