Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: ignore RuboCop remote inherited config files #3197

Merged
merged 1 commit into from Oct 4, 2019
Merged

Ruby: ignore RuboCop remote inherited config files #3197

merged 1 commit into from Oct 4, 2019

Conversation

Copy link
Contributor

@sshaw sshaw commented Oct 4, 2019

Reasons for making this change:

RuboCop config files support an inherit_from directive.

When one inherits from a remote URL, a local version is download. For example: .rubocop-https--my-remote-config.com.

Links to documentation supporting these rule changes:

From RuboCop's docs

The optional inherit_from directive can contain a full url to a remote file. This makes it possible to have common project settings stored on a http server and shared between many projects.

The remote config file is cached locally and is only updated if:

The file does not exist.
The file has not been updated in the last 24 hours.
The remote copy has a newer modification time than the local copy.

Given this, is seems appropriate for git to ignore this file.

@shiftkey
Copy link

@shiftkey shiftkey commented Oct 4, 2019

@sshaw thanks!

@shiftkey shiftkey merged commit baf1355 into github:master Oct 4, 2019
tokuhira pushed a commit to tokuhira/gitignore that referenced this issue Dec 16, 2019
r2pgl pushed a commit to r2pgl/gitignore that referenced this issue Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants