Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jouve

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Please sign up the CLA first

Please sign up the CLA first

sent it already , waiting for its validation :)

@jouve I will take a look soon :)

How did you create this PR?

I imported code from https://github.com/libexpat/libexpat at R_2_4_4 tag

I re-introduced the 3 lines here https://github.com/python/cpython/blob/main/Modules/expat/expat_external.h#L70:

/* Namespace external symbols to allow multiple libexpat version to
   co-exist. */
#include "pyexpatns.h"

the diffs about #include <expat_config.h> locations were introduced in python's version in commits like : d413c50 and in libexpat in libexpat/libexpat@59734d6

In both case by @corona10, and according libexpat/libexpat#513 for the same reason. I kept the one from libexpat.

The rest of the changes are relevant to the diff/changelog between R_2_4_1 and R_2_4_4.

I also arrived to the same result exporting the relevant patches in libexpat and re-applying them in cpython.

@hartwork Can you please take a look?

If you want/it's easier to review, I can regenerate this PR using the 2nd method I described (export the patches & re-apply), it will generate about 15 commits instead of one.

@hartwork Can you please take a look?

@corona10 I just have, and it looks sane to me, but don't have CPython glasses. What I would suggest a person with CPython glasses does, is this:

## 1. Understand CPython's deviation from libexpat 2.4.1 upstream
# git clone --depth 1 https://github.com/python/cpython  # i.e. main
# git clone --depth 1 --branch R_2_4_1 https://github.com/libexpat/libexpat libexpat_2_4_1
# diff --color=always -r -u libexpat_2_4_1/expat/lib/ cpython/Modules/expat/ | less

## 2. Understand jouve CPython's deviation from libexpat 2.4.4 upstream
# git clone --depth 1 --branch expat_R_2_4_4 https://github.com/jouve/cpython jouve_cpython
# git clone --depth 1 --branch R_2_4_4 https://github.com/libexpat/libexpat libexpat_2_4_4
# diff --color=always -r -u libexpat_2_4_4/expat/lib/ jouve_cpython/Modules/expat/ | less

The diffs are small and the diff between the diffs is also small. Again, looks good to me, but someone with CPython glasses should check for themselves as well please.

If you want/it's easier to review, I can regenerate this PR using the 2nd method I described (export the patches & re-apply), it will generate about 15 commits instead of one.

@jouve my vote for sticking to status quo, because the approach above likely works for others too and I'm not sure all these commits (with different paths and different SHA1s) add value to the Git history of CPython. Just my 2 cents.
Thanks for the PR! 👍

@hartwork Thanks, I double-check also, it looks good to me too :)

Thanks @jouve for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

Sorry @jouve and @corona10, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8aaaf7e182e22026c3487a3b86d4d7d4f0f5f778 3.10

GH-31295 is a backport of this pull request to the 3.9 branch.

Thanks @jouve for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Thanks @jouve for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Sorry, @jouve and @corona10, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8aaaf7e182e22026c3487a3b86d4d7d4f0f5f778 3.7

Sorry @jouve and @corona10, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8aaaf7e182e22026c3487a3b86d4d7d4f0f5f778 3.8

GH-31296 is a backport of this pull request to the 3.10 branch.

GH-31297 is a backport of this pull request to the 3.8 branch.

GH-31298 is a backport of this pull request to the 3.7 branch.